-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: add mailmap entries for ttzztztz and garygsc #39588
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add mailmap entry for ttzztztz and re-run AUTHORS to remove duplicate entry.
Add mailmap entry for garygsc and re-run AUTHORS to remove duplicate entry.
nodejs-github-bot
added
the
meta
Issues and PRs related to the general management of the project.
label
Jul 30, 2021
ttzztztz
approved these changes
Jul 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
BethGriggs
approved these changes
Jul 30, 2021
jasnell
approved these changes
Jul 30, 2021
jasnell
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
fast-track
PRs that do not need to wait for 48 hours to land.
labels
Jul 30, 2021
Fast-track has been requested by @jasnell. Please 👍 to approve. |
GaryGSC
approved these changes
Jul 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
lpinca
approved these changes
Jul 30, 2021
Trott
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jul 30, 2021
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jul 30, 2021
Landed in b4ae702...46e6c64 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jul 30, 2021
Add mailmap entry for ttzztztz and re-run AUTHORS to remove duplicate entry. PR-URL: #39588 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jul 30, 2021
Add mailmap entry for garygsc and re-run AUTHORS to remove duplicate entry. PR-URL: #39588 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
Add mailmap entry for ttzztztz and re-run AUTHORS to remove duplicate entry. PR-URL: #39588 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
Add mailmap entry for garygsc and re-run AUTHORS to remove duplicate entry. PR-URL: #39588 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
Add mailmap entry for ttzztztz and re-run AUTHORS to remove duplicate entry. PR-URL: #39588 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
Add mailmap entry for garygsc and re-run AUTHORS to remove duplicate entry. PR-URL: #39588 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
fast-track
PRs that do not need to wait for 48 hours to land.
meta
Issues and PRs related to the general management of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mailmap entries and re-run AUTHORS to remove duplicates.
@ttzztztz @GaryGSC If I haven't used the email addresses that you prefer for the AUTHORS file, please leave a comment. Thanks! (For garygsc, it's the gmail address, and for ttzztztz, it's the outlook address.)